Bryan Mishkin
Bryan Mishkin
Looks like we'll need a volunteer to continue working on the fix that was started in #431...
Maybe you can add an acceptance test that passes a windows-style path to the CLI? There's a config path CLI option.
From what I remember, we had trouble reproducing the issue in the test and so I wasn't confident that the test actually verified it was fixed.
Just FYI, the v4 release (https://github.com/ember-template-lint/ember-template-lint/issues/1908) is coming up in the next week or two. So if we want to make breaking changes, now is the time to do it....
Usually it's best to use an opt-in rule option to avoid a breaking change. But note that we will have another major release coming up (#2319) if breaking changes are...
I agree with improving our default behavior to match ESLint's behavior (which is a direction we are trying to move in) which sounds like it would solve this issue more...
@rtablada would you be interested to open a separate PR changing the default behavior? That way we can have that change lined up and ready-to-go for the next major release.
Yes, always using full paths seems safest, simplest, and preferred given it matches ESLint's behavior. @rwjblue is that okay with you or do you still prefer the more sophisticated behavior...
Some of these rules don't take into account ifs/branches.
Agreed, PRs welcome. Here's an example of one rule that was fixed to handle this: * #1606