Bryan Mishkin

Results 359 comments of Bryan Mishkin

We should move existing import utils to `utils/import`, likely in a separate PR. I'd like to have a complete and consistent suite of utils with clear APIs available for checking...

Thanks for the bug report! The logic for handling braces in these two rules ([require-computed-property-dependencies](https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/require-computed-property-dependencies.md) and [use-brace-expansion](https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/use-brace-expansion.md)) is unfortunately very complex and not entirely consistent. I would love to extract...

Will unused variable detection come into play at all here (this PR or future PR)? There's an ESLint API for helping the [no-unused-vars](https://eslint.org/docs/latest/rules/no-unused-vars) rule detect if variables are used, e.g....

Can you merge/rebase the latest master?

Can you post the full computed property?

It looks like you're seeing the autofix results of two rules: 1. [ember/no-assignment-of-untracked-properties-used-in-tracking-contexts](https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/no-assignment-of-untracked-properties-used-in-tracking-contexts.md) changing assignment to `set` (note: there's a ticket about this becoming a suggestion and not an autofix:...

Definitely makes sense what you're trying to do, but still I don't think the code sample is written correctly. I have seen people try to write code like that before...

A previous issue was filed about this in https://github.com/ember-cli/eslint-plugin-ember/issues/867. At the time, we decided to continue enforcing using `set` everywhere for consistency, even though it's not necessary in the constructor.

Regarding rule naming: I actually think we should name the rule from #195 `no-implicit-service-injection-argument` to be more specific about what that is referring to, and then we can name your...

I opened a PR to implement `no-implicit-service-injection-argument`: #1188