Bryan Mishkin

Results 335 comments of Bryan Mishkin

@amk221 I have opened #821 which will help improve the situation (it will address your last comment specifically). The solution @rwjblue mentioned is still our long-term goal but a very...

Yeah I think this rule needs to be rewritten to take multiple classes into account. We have other rules that handle multiple classes properly.

Search the codebase for `currentClass`, `currentEmberClass`, or `currentEmberComponent` to see some implementations. In particular, here's an example from the `no-unused-services` rule that uses a stack to keep track of the...

Yes I believe the rule should be updated to allow this. `getStaticValue` could be used to attempt to get the key(s) from any variables passed as dependent keys.

I'm not sure that it's sufficient for the rule to simply look for `var` usage outside the Ember class. There could be plenty of legitimate code using `var` outside the...

We could call this `no-overriding-builtin-services`? I would include `router` and `store` (Ember Data) for sure. Are there any other builtin services we should include? I don't think this rule needs...

First alpha release of v5 published! Please test it out and let us know if you want to include additional breaking changes before the final release in a week or...

Status: * Waiting for #2696 to be completed (CC: @gabrielcsapo @rwjblue) so I can release a final v4 version with that fix * After that is done, will release 5.0.0

Release completed: https://github.com/ember-template-lint/ember-template-lint/releases/tag/v5.0.0