eslint-plugin-ember icon indicating copy to clipboard operation
eslint-plugin-ember copied to clipboard

Published 20 hours ago • verified publisher icon ember-cli

forbid overriding builtin services

Open NullVoxPopuli opened this issue 3 years ago • 1 comments

do folks want this? should I keep working on it?

I think it could be useful, because things only go wrong when people override the router service

NullVoxPopuli avatar Oct 23 '21 17:10 NullVoxPopuli

We could call this no-overriding-builtin-services? I would include router and store (Ember Data) for sure. Are there any other builtin services we should include?

I don't think this rule needs to be configurable, since people can use the existing no-restricted-service-injections rule if they want customization.

UPDATE: see other comment thread for more discussion.

bmish avatar Oct 25 '21 16:10 bmish