Bryan Mishkin

icon indicating a website link https://www.linkedin.com/in/bmish/

icon company @vercel icon location New York City and San Francisco icon location Software Engineer @vercel. Passionate about the web, open source, and dev tools. Former @square, @eslint team, @emberjs linting.

Results 359 comments of Bryan Mishkin

[ember/no-side-effects] False-positive with an assignment in a lambda

We had some previous discussions about this case in #915 and #917. At the time, we decided not to make any changes to the rule, because closures/lambdas did not seem...

[ember/no-side-effects] False-positive with an assignment in a lambda

I'll close for now since I don't have a perfect fix for it.

False positives for `ember/use-ember-get-and-set`

What rule?

False positives for `ember/use-ember-get-and-set`

There are a few related issues like #243 if you search the issues in this repo for the rule name. It seems like this rule could potentially be smarter and...

ember/no-assignment-of-untracked-properties-used-in-tracking-contexts should not be fixable

Thanks for bringing this up. I am interested to consider how we can optimize our linting for Ember Octane best practices including using tracked properties. If needed, we could have...

no-new-mixins being flagged incorrectly

What's the file path?

no-new-mixins being flagged incorrectly

Yeah the detection is based on having `mixin` in the file path and extending an Ember object. Not great, but it also seems a bit confusing that your path has...

no-new-mixins being flagged incorrectly

You can disable the rule in `.eslintrc.js` for the entire `tests` directory. Would that help?

no-new-mixins being flagged incorrectly

I noticed that #213 would help fix this.

ember/no-test-module-for catches too many things

There are some discussions in the original PR for this rule about why we don't have an import check: https://github.com/ember-cli/eslint-plugin-ember/pull/562 CC: @NullVoxPopuli