Blake Miner
Blake Miner
I also think template errors should be emitted on the `http.log.error` logger with the WARN log level instead of DEBUG. Or, at least at the INFO level...
> If an error happens after that point in the response flow, the response will be broken either way... just in different ways. Makes sense. I don't know if HTTP...
After thinking about this issue a bit more, I want to provide some clarification: 1. Once HTTP status code and headers are sent, `handle_errors` cannot modify the HTTP response anymore;...
@Siomachkin - you are on the right track here. The encode responseWriter wrapper needs to know when an error has occurred in the ServeHTTP chain and prevent the writer from...
@francislavoie - Was just checking in to see if you had an opportunity to investigate this. I must also commend everyone on the Caddy team for somehow keeping the percentage...
Maybe, although my second suggestion of adding a `log_skip` flag when emitting errors might be sufficient and still fall under the "log emitter" category. ``` error 404 { log_skip }...
Original: ```go for _, p := range points { if p.Origin == "" && nodeID == cs.node.ID { // if this point came from the owning client, it already knows...
Fixed in #329. Thanks, @exside