Blake Miner comments

Results 138 comments of


                                            Blake Miner

fix: do not use aliased attribute for order if model name is set

@WikiRik - Are you just waiting for me to implement a test for this? Is this fix acceptable otherwise?

fix: do not use aliased attribute for order if model name is set

Listen, I will write the test, but I want to express some frustration here. I already did the SSCCE thingy, and this PR is for 2 lines of code...

Attributes values are broken if they are passed from dynamically destructured props and used in the component definition at the same time

> I have tested several solutions to this problems and I think that I will change this behavior in the next Riot.js major release. > The cleanest solution is to...

Attributes values are broken if they are passed from dynamically destructured props and used in the component definition at the same time

I think I follow now. I was confused because the example used a variable `computed` but you call it `role` in the exports. Just a typo I think. My understanding...

Attributes values are broken if they are passed from dynamically destructured props and used in the component definition at the same time

> OMG, I have no idea how I will migrate my codebase but I LOVE IT I agree. This is a welcomed change. I have been running Riot v10 beta1...

bug with recent v6.21.4 minified aliases in ORDER BY clause

Culprit commit is likely 5a257bc93c7e760f6b0158f55b3cb48878698450. See PR #14804.

bug with recent v6.21.4 minified aliases in ORDER BY clause

I'll try to get the SSCCE out at some point soon. The problem happens when using the `order` as a multi-element array as [documented here](https://sequelize.org/docs/v6/core-concepts/model-querying-basics/#ordering). For example, the following query...