Bruno Santos

Results 9 comments of Bruno Santos

Are you using the ForkTsCheckerWebpackPlugin in webpack?

Ah :) Yeap, It works great. At least never noticed a problem until now. The only problem I faced so far was with returning a Deferred for an array type....

The schema registry might suffer from the same problem. Would it be viable to make both `schemaRegistry` and `keywordRegistry` scoped to the jsonschema.Schema instance? Was looking into @carolynvs fix, and...

@Arqu Is @carolynvs implementation what you were thinking as a solution to this ticket? I'm in need of a solution to this, and willing to work on it. My plan...

@Arqu do you think this is something that could be merged in?

> The struct isn't cleared on a new substate and keys can easily collide depending on usage. Not clearing the struct was the whole point of adding the new field....

Wouldn't it be possible to just register `definitions` as a keyword using the jsonschemas.NewDefs handler for it to work in a compatible mode? ``` jsonschema.RegisterKeyword("definitions", jsonschema.NewDefs) jsonschema.LoadDraft2019_09() ```

I've used this approach and haven't detected any problem so far. @rbren does it work for you?

Maybe adding an option to the plugin config to include the metadata could be a good compromise on the concern of the increased content size.