bmalinowsky

Results 24 comments of bmalinowsky

I don't understand your first bullet point, when a user connects GAs to a tunnel and the tunnel's PA has no device toolkey? Please try again :) For the second...

Having the addresses of other secure interfaces in the sender list is fine, as they can actually be senders, too. For group diagnostics it would make sense to ignore those...

Maybe to add: although I currently don't check the sender address in the client implementation against the sender list for standard data secure (i.e., not GO diag), it is better...

I looked at the implementation for checking group senders, and that will use a different map in `Security`. The current `groupSenders` is really there for having a basic set of...

Interfaces are now filtered out during keyring import, so the problem with the device toolkey should be gone.

The "no-day" encoding makes the day field optional for that dpt, because many time sources in knx don't have a notion of day-of-week. It doesn't mean or require to literally...

This is likely a regression, it works with `v1.5.0`. Probably due to using `MethodHandles.publicLookup()` in #119. Having `main` in a package-private visible class is valid.

@J-N-K In the previous weeks I reviewed most of the translator implementations for some other reason, and parsing under-specified string output should not be the preferred way of obtaining required...

@holgerfriedrich What's the progress on this? Any issues with the security implementation in 2.5 can still go into 2.5.1.

I'm assuming you are solely talking about IP nets? The calimero server can filter KNX messages (like with the group address filter table), but then you wouldn't be able to...