Brian Malinconico

Results 24 comments of Brian Malinconico

I see you mentioned some validity to the overall idea in the other health check thread. I'd be happy to craft the PR for this functionality if we can agree...

@mperham I reviewed the connection reaping in ActiveRecord and it is spawning a sleeping thread (https://github.com/rails/rails/blob/157920aead96865e3135f496c09ace607d5620dc/activerecord/lib/active_record/connection_adapters/abstract/connection_pool.rb#L335) If ConnectionPool will handle the termination of the Connections, should it also take a...

I'm fine with picking an expected method and calling it a day. > Print out a warning if we reap something that doesn't implement close? Printing a warning would be...

Thanks @zeertzjq that looks like it is the same thing, but totally unexpected behavior for me. I'm fine with this being the default if that is what the author(s) choose.

Ah looks like overloads are only allowed in the stdlib and that test file ``` constexpr string_view whitelistedTest = "overloads_test.rb"sv; if (((file.isPayload() || file.isStdlib()) && owner != Symbols::root() && (owner...

I realize this is a fairly trivial ask, assuming I'm not missing some obvious functionality. I'd be happy to implement.

I'm specifically looking to remove bearer tokens, and the way the GRPC Gateway works they show up in a couple of headers. I'm personally looking to remove parts of it...

A quick note to anyone using @Qqwy's work around. `T::Utils.signature_for_method` evaluates the sig block and could introduce dependency load order issues. ``` class Foo # This fails because the block...

Sorry I missed the last response and am just recently back in this code. I've got two issues that I'm trying to solve: 1) The content of the authorization header...

@philjones88 Possible solution that works for my usage: https://github.com/btroncone/ngrx-store-localstorage/pull/94