Bjorn Lu

Results 767 comments of Bjorn Lu

I was able to get dev working by specifying `vite.ssr.noExternal: ['react-aria', 'react-stately', '@react-stately/*', '@react-aria/*']`. Same for #4093 too with `vite.ssr.noExternal: ['downshift']`. The reason we need to do so is that...

Well turns out the build fails because now `preact` suffers from [dual package hazard](https://nodejs.org/api/packages.html#dual-package-hazard). Astro calls `preact-render-to-string`'s ESM code, which import preact in ESM, and some deps only export CJS,...

@mayank99 I added docs in #4267 which hopefully clarifies things a bit. From the repro here and at #4093. The build is still failing as: 1. This repro: `@react-aria/datepicker` is...

Yeah the packages above are built for bundlers only, and not very friendly in nodejs, so it may be worth opening an issue on the respective packages. Those should be...

Looks like the reason the warning isn't reported by Vite is because it only reports for non-ssr transforms, in which case we're running in SSR instead. I feel like it's...

This should be fixed upstream in Vite 3.0.9 which the latest Astro version uses. It will now warn when the import can't be resolved in dev mode as it needs...

Thanks for the hint @rkuprella. Indeed it looks like the case here too. BlogImage (from `blogimage.astro`) is being created with `client:visible`, which isn't valid for an astro file. There should...

Tried to take a stab at this for a warning. So it seems like because `@astro/mdx` compiles into JSX, we don't have warnings setup as usually JSX is considered a...

I managed to trim down the issue to Vite's SSR transform, which incorrectly transforms: ```js export * from 'vue' import {createApp} from 'vue' export {createApp as bar} ``` to ```js...

Note: This should be good when https://github.com/vitejs/vite/pull/9554 is released and the Vite version used by Astro is bumped (currently pinned). And also a combination of the fix in [this branch](https://github.com/withastro/astro/tree/preact-compat-issue).