Bjorn Lu

Results 767 comments of Bjorn Lu

I can reproduce the issue with the zip file repro in Vite 2.8.6. But based on https://github.com/vitejs/vite/issues/3413#issuecomment-908867958, it may also be an issue with `antv` incorrectly publishing their packages. `ESM`...

The cache currently contains metadata on per-project basis. I'm not sure sharing it is a good idea and might make the whole flow even complex and slower. Because we now...

@Dunqing do you mean you're willing to make a PR for the proposed feature?

Hi, @andreavaccari summoned me. Making packages work with bundlers and node can certainly be a challenge, but I think there's certain improvements can be made as @andreavaccari suggested. Even with...

`.mjs` is preferred mostly because it's faster for internal implementations to detect whether a file is ESM or not. Using `{"type":"module"}`, they'd otherwise have to walk up the filesystem to...

I can reproduce this on macos too. It's because the file at `/@id/astro/runtime/client/hmr.js` has a sourcemap url prepended like `//# sourceMappingURL=astro_runtime_client_hmr__js.js.map`. In the basic example, the url doesn't get prepended...

I think I figured out how the sourcemap url got there. So it seems like when we import `/@id/astro/runtime/client/hmr.js`, Vite is resolving to the one in optimized deps as that...

It doesn't look like there's a separate issue, or is fixed with a different PR. Re-opening.

My bad. Added changesets and pinned Vite to 3.0.5