Yunjong Jeong (ollie)
Yunjong Jeong (ollie)
To fix for the linter, please run following commands as decribed in https://github.com/klaytn/klaytn/blob/dev/HOW-TO-LINT-YOUR-CHANGE.md. ```bash # At 'klaytn' directory gofumpt -w . goimports -w . ```
@nohkwak Please fix as follows. Apparently `gofumpt` and `goimports` is not enough to satisfy the linter. ```diff diff --git a/consensus/istanbul/backend/engine.go b/consensus/istanbul/backend/engine.go index 2bf5a79b..727d66ef 100644 --- a/consensus/istanbul/backend/engine.go +++ b/consensus/istanbul/backend/engine.go @@ -28,8...
How about saying "Protected API" or "Privileged API" instead of "Banned API"? "Banned" sounds like some users are banned from an API. What you want here is preventing remote access...
Is the purpose of new `Server.scheme` field is to selectively apply the ban list? Why don't you let the callers of `RegisterName()` determine that? For instance, in HTTPServer, the ban...
@hyunsooda It should not be removed. The code will be used by - chains with KIP71Hardfork = nil - chains with KIP71Hardfork block number, but before the block number. I...
> My question was whether to remove `updateUnitPrice()`, not the `SetGasPrice()`. Or maybe I'm missing your point? @hyunsooda I meant to keep both `updateUnitPrice()` and `SetGasPrice()`. We can support the...
@hyunsooda Good point. I see that `UpperBoundBaseFee == LowerBoundBaseFee` is equivalent to setting `UnitPrice`. ## When can we remove it But before remove an existing feature, we need to carefully...
@kjeom I agree that simply using UnitPrice is much more intuitive. @hyunsooda Why do you think we should remove the function? We can remove it, but at the cost of...
Hi @gitmewai, thanks for the report. The version v1.9.0 contains relevant patches (https://github.com/klaytn/klaytn/pull/1527, https://github.com/klaytn/klaytn/pull/1549). The patches eliminate out-of-bound slice accesses in `blockchain/vm/memory.go`, which appears in your logs. Could you check...
@ian0371 Regarding changes in `ItemsAt` API, please check that KIP71 items exist (1) before magma fork, (2) after magma fork, (3) after magma fork and voting. @JayChoi1736, can we add...