Daniel Hahler

Results 1440 comments of Daniel Hahler

@davidhalter Should be good as a daily driver for testing already. I'd like to finish this soon.

@davidhalter yes, please test/use it. Note that there are two methods for Vim already, but it's better to test the newer one.

> Are the color changes intentional? I'm totally fine with them, there's just a lot of commits and I'm not sure where some of them come from. Not necessarily, I...

> As far as I can see, the signatures colors are still missing (I pulled just now). Maybe you can look at this again. Are you using Vim 7.4.X still?...

> What methods would be needed to get the colors working on 7.4? I assume they are broken in Vim without the popup window then in general - will have...

> What methods would be needed to get the colors working on 7.4? I cannot really tell what you are missing there. Are you using a colorscheme? Using the following...

For reference, this is how it looks on this branch with my config (Neovim, and Vim, using the new method (`let g:jedi#show_call_signatures = 3`): ![2019-12-06-101716_938x188_escrotum](https://user-images.githubusercontent.com/9766/70311269-a03bb680-1811-11ea-8ab5-957697cc58f1.png) With `let g:jedi#show_call_signatures = 1`:...

@davidhalter > BTW: While there's obviously conflicts, I'm still interested in this change. If you think this is still in a good shape, we should probably just merge it and...

> What do you think about using show_call_signatures = 1 for floating windows and 3 for the conceal stuff? In case the VIM version is not good enough, we could...

There's some work that needs to be finished in https://github.com/davidhalter/jedi-vim/pull/652. Maybe you can try/revisit the PR/branch (blueyed:call-signatures) from there? (Sorry, I've only skimmed the contents of your issue, but figured...