Daniel Hahler

Results 1440 comments of Daniel Hahler

@davidhalter Are you actually using it for normal mode? (I found this a bit too confusing myself)

@copy Thanks for your review and testing! > couldn't we get rid of the conceal stuff and just put the call signature in the buffer directly? The conceal stuff is...

> Still, the buffer replacement can be simplified by removing the original code from the "magic" line. Sounds good. Can you make a comment on the actual code, please?

@copy The escaping should be fixed now.

Using this as a daily driver now again myself. Found a good workaround when using python-pep8-indent: https://github.com/Vimjas/vim-python-pep8-indent/pull/98, which will use the orig lines that jedi-vim stores now before concealing.

Hopefully fixed the tests by now (review carefully!). I think this could be merged soon in general - revisited all the previous comments also.

@davidhalter This is huge (sorry!), but really useful in general and has gotten quite some good feedback from others. Now it is waiting on yours, and then I will clean...

@davidhalter better wait.. I have WIP here to use Vim's popup / Neovim's floating window here additionally, deprecating the conceal method. But input would be appreciated already on how to...

> we just ditch conceal. It has been a pain point for so long. well, we can keep it for older Vim versions, no? Apart from that the idea was...