Deniz Mert Edincik

Results 436 comments of Deniz Mert Edincik

> oh yeah, good catch! The test still fails with the same error though. 😅 createEmptyVault inside vault interface, it should be on contract interface I guess. tried to do...

This is great contract by functionality, but I think terrible UX. I suggest to improve: - Let's get rid of capability part ( I mean user facing part ) RemoveVault...

@joshuahannan yeah you are right, `Address` is needed there. Or we can make it: `AddVaults( [PublicPath] )`, `AddVault( PublicPath )` ( which we can call after we save the switchboard...

> pub fun addNewVaultsByPath(paths: [PublicPath], address: Address) this looks ok to me, just commenting something small on implementation.

great idea. Just code is little too complex now to grasp at first sight. maybe something like this? ```cadence pub fun safeDeposit(from: @FungibleToken.Vault): @FungibleToken.Vault? { // Try to get the...

Hey @justjoolz, This is very good idea, few suggestions: - I feel there is a need for `Ticker Symbol` - `tokenID` and `tickerSymbol` ( if added ) should be guaranteed...

Ah I just got the tokenId, this is good point. I think having 2 standards (when multiple already covers single use case with tokenId=1) can be confusing for adaptation. Also...

> It seems to me that nobody really cares about events coming from fungible token contracts that don't include the address of the account that owns them, so I though...

@joshuahannan In this current situation, actually this is correct fix. But my point was about the bigger picture a bit. Maybe the main problem is having `owner = nil` where...

You need to go account 0x1 and click deploy contract