Jun Kimura

Results 26 comments of Jun Kimura

I wrote an example of a design pattern for middleware contracts in the following gist: https://gist.github.com/bluele/39378422eb8c1cd55dfa5702b43978e0 In this example, I demonstrate the implementation of middleware that can be applied to...

@dzmitry-lahoda > // fee -> hook -> app -> base > looks wrong Ah, sorry, that code comment is confusing. I have fixed https://gist.github.com/bluele/39378422eb8c1cd55dfa5702b43978e0 > on receive fee -> hook...

To make this design pattern available, the following modifications would be required: - implement `sendPacket` to the `IBCAppBase` - modify Apps(i.e. ics-20) to call `sendPacket` when sending packets

Since we are currently using truffle&npm to manage external dependencies, probably you need to do `npm install` before `forge test`. might be helpful: https://github.com/hyperledger-labs/yui-ibc-solidity/blob/main/.github/workflows/test.yml#L4

There are no concrete plans yet, but it may be worth considering. cc: @hyperledger-labs/yui-committers

> Maybe the Packet itself could have an optional field specifying the serialization format of the data. I think it makes sense to use ChannelEnd's `version` to determine which packet...