Billy Keyes

Improve error behavior when loading policies

1

As reported in #405, Policy Bot will sometimes fail to discover a policy file due to a GitHub timeout (or other network error.) When this happens, we post a failed...

Add server-level option to filter review request users

1

Internally, we have several service accounts that have elevated permissions in organizations. When using reviewer assignment for rules that are permission based, I often see service accounts assigned as reviewers,...

#504 added basic support for SSH commit signatures, but only for the `has_valid_signatures` and `has_valid_signatures_by` predicates. Because SSH keys use fingerprints instead of IDs, we should also add a `key_fingerprints`...

Errors loading config larger than 1MB

2

I _think_ this has been broken since we introduced the `appconfig` package, but it's also possible that GitHub's API changed. The `GetContents` method returns content if the file is less...

Error saving config with commands that contain '&'

3

We discovered yesterday that trying to save a build with an '&' in the publish or verify command will cause a 500 error and not save the change. From the...

Notifications for publish builds

2

@mnazbro pointed out that while Gerrit CI comments on CRs when verification builds start and finish, it doesn't comment on anything for publish builds. While it's not obvious to me...

Typing '/' in command fields switches focus to search box

1

When editing commands, typing '/' triggers the Gerrit keyboard shortcut for search and switches focus to the search box. This makes it hard to entry commands like `./scripts/publish.sh`, forcing you...

After switching to JDK 8, `doclint` revealed a bunch of problems with the docs. I currently have this linting disabled in `gradle/javadoc.gradle`, but we should actually fix all the warnings...

https://github.com/palantir/giraffe/blob/03182397d7a0476df192094f2730ea169b4979e8/ssh/src/main/java/com/palantir/giraffe/ssh/internal/SshSameHostFileHelper.java#L33 https://github.com/palantir/giraffe/blob/03182397d7a0476df192094f2730ea169b4979e8/ssh/src/main/java/com/palantir/giraffe/ssh/internal/SshSameHostFileHelper.java#L63 The `-n` flag (to prevent overwriting existing files) is not part of the POSIX specification for the `cp` or `mv` commands. Giraffe guarantees that it will work with...

Add utility for streaming command output to logger

1

The current method looks something like this: ``` java CommandFuture future = Commands.executeAsync(cmd); ResponseProvider responses = UnorderedResponseProvider.builder() .addRegex(".*", new Function () { @Override public Runnable apply(final String input) { return...