Billy Keyes

Results 159 comments of Billy Keyes

In light of #30, I've been thinking about this more and am now planning something like this: 1. All apply functions take an `io.Reader` which may implement additional interfaces 2....

While it would probably work most of the time, I don't think we can guarantee that the `onError` function will always rollback the transaction, due to the way `database/sql` implements...

I looked through the `database/sql` API again and I was wrong earlier about `sql.Tx` being the only way to control connection usage. There's also `sql.Conn`, which sounds like it does...

Ah, I didn't realize this was a new Go 1.9 feature when I posted my last comment. What's the policy for this library on using new language features? Would that...

Thanks for proposing this. After some thought, I have two points I'd like to discuss before moving forward with an implementation. First, a user of `TokenSource` does not know when...

One catch: if an event blocks waiting to retry and then additional events are processed while it is waiting, the final observed state may be inconsistent. For instance, consider Policy...

If there's a reason to modify the session handling, I think we should look for alternate libraries. `scs/v2` makes two major changes that I found difficult to work with compared...

This is also an issue for field names: ``` java.lang.RuntimeException: com.fasterxml.jackson.databind.exc.InvalidFormatException: Cannot deserialize Map key of type `com.palantir.conjure.parser.types.names.FieldName` from String "Name": not a valid representation, problem: (java.lang.reflect.InvocationTargetException) null at [Source:...

Hey @jniltinho, it sounds like you found a solution for this by setting `POLICYBOT_PORT`. If that still doesn't work, or you need to use exactly the `PORT` variable, we may...

Most of this workflow is possible except for the final request: there is no way to selectively re-request reviews based on the files changed. Because the `invalidate_on_push` option applies at...