Billy Keyes
Billy Keyes
https://github.com/palantir/policy-bot/blob/fec2ebf5db5c2c26a49a3675fd2ec61b46cfa6e3/server/handler/status.go#L134-L139 Because statuses match with commits, not PRs, we start out by only preparing a repository context. Once we look up the PRs, it would be good to attach the...
It would be really sweet if I could leave a comment on a PR to ask policy bot to do the validation and post back whether it is valid _Originally...
Currently, we audit for malicious status updates by looking at the name of the user who created the status and matching it against the name configured in the server. This...
One of our internal projects has a high rate of PR creation, which means that PRs that are open for more than a day or two are likely to have...
It would be helpful if policy-bot support a way to set default options for all rules in a policy without copying code or using YAML references. I'm imagining something like...
https://github.com/palantir/go-githubapp/blob/e6f4865447e65335e1cb8787d1d25db843e0a14f/githubapp/context.go#L35 `go-github` has a variety of repository-like objects, notably `Repository` and `PushEventRepository`. Since `PrepareRepoContext` only cares about a few fields accessed via getters, we should define an interface to accommodate...
It would be helpful if the client creator provided an option to enable delays and retries in case of rate limiting. This should be optional because GitHub's hourly buckets mean...
I realized today that `http.Server` instances have an `ErrorLog` property that they use to log internal errors with connections. We should consider replacing this with a Zerolog wrapper so that...
We recently found an internal PR where someone had effectively merged a branch with itself. When processing approvals for the PR, the `sortCommits` function https://github.com/palantir/policy-bot/blob/55d042dbd89e1124d53be5ed05c89fbddc901c4b/policy/approval/approve.go#L449-L468 orders commits by their parents,...
#556 enabled `linux/arm64` builds, but only for distributions. The current version of Godel / distgo does not support building multi-architecture containers unless using an internal-only plugin. We'll need to wait...