blueoil

blueoil copied to clipboard

Add type annotation to Python scripts.

1

Todo: Add enhancement label.

lm-noshiro

Avoid the implementation depended on the order of dict

1

In `lmnet/executor/train.py` and `lmnet/executor/evaluate.py`, we have implementations implicit depended on the order of `dict` object as follows. https://github.com/blue-oil/blueoil/blob/8055a4a29618d79cf70d068d5aac5af7a4f3351e/lmnet/executor/train.py#L127 https://github.com/blue-oil/blueoil/blob/8055a4a29618d79cf70d068d5aac5af7a4f3351e/lmnet/executor/train.py#L238-L239 `metrics_placeholders` and `metrics_values` are the lists generated by `metrics_ops_dict`, but it...

hadusam

in `tools/debug.py`: ```py class QuantizedMatrix(object): ARRANGEMENT = ['Sequential', 'BitInterleaving', 'WordInterleaving'] // here ... ```

lm-noshiro

Class Resize and ResizeWithMask does exactly the same

1

`Resize` https://github.com/blue-oil/blueoil/blob/master/lmnet/lmnet/pre_processor.py#L278-L294 `ResizeWithMask` https://github.com/blue-oil/blueoil/blob/master/lmnet/lmnet/pre_processor.py#L242-L258 Maybe it's better to use a flag in `__init__` to include mask during initialization in `Resize` class to remove redundant code? then remove the other one?

Joeper214

IN #455 , tkng-san improve sort oder by `isort`. But some of the files are not ordered. https://github.com/blue-oil/blueoil/blob/master/blueoil/templates/lmnet/classification.tpl.py#L17 We apply isort again and set to CI. note: Please do this...

iizukak

print() is not suitable for logging

5

Now entire blueoil modules use `print()` as logging, but this should be logging class for better user experiences.

kchygoe

Add example config files and source codes

1

In orde to easily start blueoil for new user, we have tutorial documentations. Current [tutorial at documentation site](https://docs.blue-oil.org/tutorial/image_cls.html) have the chapter of generating config, but it occur problems. * The...

ruimashita

dlk tests failed with uncertain errors

3

Some dlk tests failed without changes of dlk source codes. http://jenkins.leapmind.local:8080/job/blueoil_dlk_test/1424/console ``` ImportError: No module named nnlib ``` ``` python: can’t open file ‘testing_code.py’: [Errno 2] No such file or...

hadusam

No config yaml reference at documentation site

1

There are no config yaml reference at documentation web site. Need to write what option can use, which parameter can select in the option, like this: https://docs.docker.com/compose/compose-file/compose-file-v1/

ruimashita

consider to remove matplotlib dependency

4

It might be possible to remove a dependency matplotlib. (Though I'm not sure...)

tkng