blueoil
blueoil copied to clipboard
Class Resize and ResizeWithMask does exactly the same
Resize
https://github.com/blue-oil/blueoil/blob/master/lmnet/lmnet/pre_processor.py#L278-L294
ResizeWithMask
https://github.com/blue-oil/blueoil/blob/master/lmnet/lmnet/pre_processor.py#L242-L258
Maybe it's better to use a flag in __init__
to include mask during initialization in Resize
class to remove redundant code? then remove the other one?
@iizukak ResizeWithMask seems to be a pre-process used in Segmentation.
I searched for ResizeWithMask, but it doesn't seem to be in use. https://github.com/blue-oil/blueoil/search?q=ResizeWithMask&unscoped_q=ResizeWithMask There is no config file used. In addition, ResizeWithMask is not tested.
Segmentation's config file uses Resize. https://github.com/blue-oil/blueoil/blob/a0078e1e0225dc627c5010429ea5f55d86af39d3/blueoil/configs/core/segmentation/lm_bisenet_quantize_camvid.py#L24 People may think that this is an unnecessary function
Deleting ResizeWithMask merit
- Removing unused functions can reduce maintenance costs
de-merit
- There is a class called ResizeWithGtBoxes, which is a bit inconsistent.
use a flag merit
- There is a class called ResizeWithGtBoxes, which is a bit more consistent.
de-merit
- The functions need to be maintained.
Which is preferable?