Ben Pfaff
Ben Pfaff
Oh, that part should be pretty easy. Is `env!("CARGO_PKG_VERSION")` sufficient to store as the runtime version number or is there something better or more detailed?
> [feldera/crates/pipeline-manager/src/db/types/program.rs](https://github.com/feldera/feldera/blob/12a5a64d60770bfcf6ef4f76a2ae0def17fa57e8/crates/pipeline-manager/src/db/types/program.rs#L314) > > Line 314 in [12a5a64](/feldera/feldera/commit/12a5a64d60770bfcf6ef4f76a2ae0def17fa57e8) > /// A selector for the runtime to use. > > maybe this? That looks good, do you happen to know whether...
@snkas Does this need a round of review now you're back?
> the error message is that any subsequent compilation fails with SIGKILL That's weird. That's typically what an oom killer uses. I'd expect the OOM to fail that way, but...
I think we collect adequate metrics now; the issue won't help us with adding more, so I'm closing it.
> [@vvuk](https://github.com/vvuk) the format is simple but the timestamp seems tricky, how can i align the timestamp with samply's internal timeline, is there any public api for generate timestamp which...
> There's actually already support on mac/linux for parsing a `marker-{pid}.txt` file that a process opens, however the file format is extremely simple (literally "[time] [name]"), which is not good...
Thank you! I submitted https://github.com/Amanieu/atomic-rs/pull/42.
Fixed with PR #42.
@Karakatiza666 Is this ready for review?