Ben Pfaff comments

Results 96 comments of


                                            Ben Pfaff

Large amount of unaccounted memory with storage enabled

The cache is currently limited to 256 MB/worker, so, for 16 workers, up to 4 GB of that could be cache.

[SQL] Move more of the Cargo.toml generation in the SQL compiler

@mihaibudiu What's the status of this PR?

nix::unistd::daemon will kill all other threads

[This issue](https://github.com/rust-lang/rust/issues/39575) indicates that forking a multithreaded process was considered unsafe enough that [`before_exec`](https://doc.rust-lang.org/stable/std/os/unix/process/trait.CommandExt.html#method.before_exec) was marked unsafe and deprecated and replaced by [`pre_exec`](https://doc.rust-lang.org/stable/std/os/unix/process/trait.CommandExt.html#tymethod.pre_exec). So it seems to me that, by...

nix::unistd::daemon will kill all other threads

> Good find. Would you care to submit a patch? Done, see https://github.com/nix-rust/nix/pull/2664. It was counterintuitive having to add a changelog file with the PR number in the name, since...

Would be nice to be able to `collect()` into TopicPartitionList

It looks good to me, thank you!

[SQL] Design a mechanism to silence particular warnings

I thought SQL didn't have variables.