Borja Lorente

Results 50 comments of Borja Lorente

Hello, @AlexBurdu ! I'm sorry for the long delay. I finally got a few cycles to look into this, and (perhaps unfortunately) I can see the gutter icons. I created...

I've tried to repro the issue you mention on a branch on top of https://github.com/bazelbuild/intellij/pull/5567 ([branch](https://github.com/blorente/intellij/blob/blorente/repro-oss-issue-with-proto-in-proto/examples/go/with_proto/proto/BUILD.bazel)), and I haven't been able to. The symbol `embedded.Message` in [here](https://github.com/blorente/intellij/blob/dd129fb6ee5f5a0e3f82c357544db949c72efa3b/examples/go/with_proto/proto/translators.go#L11) seems to resolve...

@mai93 @tpasternak could I have a review on this? I'll give co-author credit to @tingilee on the merge commit, but they don't have their branch open to pushes.

I'll solve the WORKSPACE conflicts, it just never ends so I'll wait for a review before solving them again.

I've addressed the comments (and added a comment on why we import `grpc`). @mai93 @tpasternak , could you please take a look now?

Rebased on top of `master` and implemented https://github.com/bazelbuild/intellij/issues/5550 in the last two commits.

Addressed the comments, sorry for the delay but it was hard to find time, as per usual.

Hello! Instead of importing the project in the second IDE, could you try just "Open"ing the project? It's a bit counter-intuitive (it has bitten me a few times), but importing...

This is intentional as per https://github.com/bazelbuild/intellij/pull/4786 The heuristic introduced there goes like: If there is a "main" function _and_ a `cc_test` target, please treat it as a test. It's definitely...

Thanks @fmeum for the quick response! If that is the case, I might be misreading t[he documentation on repository rule evaluation](https://bazel.build/extending/repo#when_is_the_implementation_function_executed). I think this is the relevant passage: > The...