intellij
intellij copied to clipboard
bazelbuild
(rebase) Support embedded go_proto_library
This is just a rebase and cleanup of this PR from @tingilee : https://github.com/bazelbuild/intellij/pull/5567. The feature work is entirely theirs.
@mai93 @tpasternak could I have a review on this? I'll give co-author credit to @tingilee on the merge commit, but they don't have their branch open to pushes.
I'll solve the WORKSPACE conflicts, it just never ends so I'll wait for a review before solving them again.
LGTM, thank you @blorente
The only concern is about the new dependencies we add (in WORKSPACE.bzlmod). @mai93 can you please confirm they're ok?
The only concern is about the new dependencies we add (in WORKSPACE.bzlmod). @mai93 can you please confirm they're ok?
I think since bazel-gazelle is part of bazelbuild it should be fine.
The only concern is about the new dependencies we add (in WORKSPACE.bzlmod). @mai93 can you please confirm they're ok?
I think since bazel-gazelle is part of bazelbuild it should be fine.
It's also google.golang.org/grpc
google.golang.org/grpc
I'm not sure why it should be concerning? cc @blorente if you have more details about it
It's not concerning. It's just a new dependency so I always have concerns, sorry
Ok, so if there are no issues with dependencies (cc @mai93), then it LGTM. Btw is org_golang_google_grpc actually used anywhere?
I've addressed the comments (and added a comment on why we import grpc). @mai93 @tpasternak , could you please take a look now?