Bret Little
Bret Little
Closing for lack of feedback. Please re-open if still a problem.
@frandiox I like it. Will discuss in the hangout today and report back.
@frandiox a few thoughts after discussion: 1. Keeping `primaryData` and `secondaryData` in separate functions makes them slightly more self documenting and obvious. 2. Adding an extra function also creates more...
@frandiox updated! Thx for the review!
@frandiox I think there's something unrelated causing the inf loop. I update `Footer.tsx` with `` and it goes away. Additionally, swallowing the async query error is probably undesirable, because the...
@frandiox I assumed this wouldn't be an issue because we added this https://github.com/Shopify/hydrogen/pull/1318/files and subsquently this: https://github.com/Shopify/hydrogen/blob/main/packages/hydrogen/src/utils/callsites.ts#L43 So all promises from our API clients should handle uncaught promise exceptions?
> First of all: being more defensive and adding catch for error is always a good thing 👍 Being defensive is good, but adding catch statements in the wrong layer...
Additionally, I can't get the express/node example to break with an uncaught promise exception from a loader: ```ts export async function loader() { return defer({ test: new Promise((resolve) => {...
By default, Hydrogen is setup to run on Oxygen. Oxygen uses a worker runtime, not NodeJS. This means you cannot use NodeJS APIs. If you'd like to deploy to Node,...
I'm looking into this, and I think it's because `@remix-run/server-runtime` was not properly moved to be a peer dep of `@shopify/remix-oxygen`