Bret Little

Results 155 comments of Bret Little

@michenly I agree that it should be inside our abstraction. It was always my concern that it would be forgotten if left to the user on the outside. I'm just...

I'm curious, why are "react" and "react-dom" inside there? Are those necessary? They aren't in the skeleton template vite config.

I did some testing, and it worked well! Great job! One package for some reason it did not automatically optimize is `warning`: https://www.npmjs.com/package/warning

It looks like warning broke when I just imported it bare. Not sure why this would make a difference ![image](https://github.com/Shopify/hydrogen/assets/1566869/c184a7e3-0d6f-4d30-b97b-d82dc0b58f1f)

Hi @EricSimons thank you for the response! It's great to hear that Node 16 is WIP. The specific features we rely upon are the [`ReadableStream` API](https://nodejs.org/api/webstreams.html#example-readablestream). Though I'm currently exploring...

It appears to work, the total start-up time seems correct. But in all honesty, I can't get the cpuprofile to actually be helpful ![image](https://github.com/Shopify/hydrogen/assets/1566869/7ff79296-ca0c-4e8e-a984-21699653dcfc) ![image](https://github.com/Shopify/hydrogen/assets/1566869/2be425e9-77ba-496d-b9a9-e8f5bf6a1c32)

Do you have a different error message now that git is installed?