hydrogen
hydrogen copied to clipboard
Don't filter product options with only one value in the VariantSelector
WHY are these changes introduced?
We are in the process of simplifying and improving the components offered by Hydrogen. As a part of that, it's been requested that the VariantSelector component be changed to not filter out options that have only one value. This is a breaking change.
See the changeset for an example on how to migrate.
Fixes #1198
HOW to test your changes?
- Make sure that the skeleton template does not display product options for a product that does not have more than one value. For example: /products/shopify-wax
Post-merge steps
Checklist
- [X] I've read the Contributing Guidelines
- [X] I've considered possible cross-platform impacts (Mac, Linux, Windows)
- [X] I've added a changeset if this PR contains user-facing or noteworthy changes
- [x] I've added tests to cover my changes
- [ ] I've added or updated the documentation
Oxygen deployed a preview of your bl-variant-selector-filter branch. Details:
| Storefront | Status | Preview link | Deployment details | Last update (UTC) |
|---|---|---|---|---|
| subscriptions | ✅ Successful (Logs) | Preview deployment | Inspect deployment | June 12, 2024 8:56 PM |
| custom-cart-method | ✅ Successful (Logs) | Preview deployment | Inspect deployment | June 12, 2024 8:56 PM |
| Skeleton (skeleton.hydrogen.shop) | ✅ Successful (Logs) | Preview deployment | Inspect deployment | June 12, 2024 8:56 PM |
| optimistic-cart-ui | ✅ Successful (Logs) | Preview deployment | Inspect deployment | June 12, 2024 8:56 PM |
| third-party-queries-caching | ✅ Successful (Logs) | Preview deployment | Inspect deployment | June 12, 2024 8:56 PM |
| vite | ✅ Successful (Logs) | Preview deployment | Inspect deployment | June 12, 2024 8:56 PM |
Learn more about Hydrogen's GitHub integration.
Okay, I'll hold off merging.