zc he

Results 139 comments of zc he

@mkatychev Thanks a lot for the reviewing. The removing of newline in extras #139 does seem to cause a lot of trouble. As I recall, it mainly solves the issue...

> Ideally a list node should have a simple definition: list: ($) => seq('[', repeat1(choice( ',', $._list_entry, '\n'))), You mean getting rid of `list_body`? That will be a breaking change...

@mkatychev Oh, I think I remember what was the problem: There's a fundamental difference between ```nushell (foo bar # bar is the argument of command foo ) foo bar #...

I think moving `terminator` to the external scanner is a simple and feasible way. Closing this for now.

Hi @mkatychev, I've managed to fix most of the `_terminator` related problems mentioned above in [this branch](https://github.com/blindFS/tree-sitter-nu/tree/newline_in_extra) Then I found another trickier problem: To prevent `echo 192.168.0.1` from being parsed...

> Would you mind elaborating on `echo 192.168.0.1`? I'm confused as to how full stops are involved Actually I'm not quite sure how it ended up like that (after conflict...

> Will you please start working on this, topiary-nushell is not working because I used the new syntax in my scripts I'd suggest to use the equivalent quoted syntax in...

#898 Probably fixes this issue, works for most terminal apps on macOS.

> [@blindFS](https://github.com/blindFS) It has not been fixed on Windows yet. Have you tried manually compiling nushell with a patched version of reedline?

@luckzilong No worries, you can wait for future nushell releases if it gets merged.