Ben Lerner
Ben Lerner
Aesthetically I don't think you quite want to use those, because honestly a bunch of the colors tend towards the olive-greeny-orange chunk of the color wheel... Also, even though pairwise...
No. I think this may be the sort of thing we'd like to have as a community-supplied library, but I don't think we need it to ever be "baked in"...
not c++! it's TypeScript
How does this interact with on-key handlers? Which happens first? Do we call both on-key and on-raw-key for sustained keypresses? Or do we make it a well-formedness error to have...
(Docs: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key and https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key/Key_Values)
In chrome, the two images are different *during the image testing process*:  vs  (look super close at the black lines separating the tangency points between the circles) But...
Nono, not quite. Try Joe's code in the repl, and the images are identical. The two images I show there are the ones that are rendered by BaseImage.prototype.equals, which is...
After digging into this with @schanzer , we think the problem has to do with https://github.com/brownplt/code.pyret.org/blob/horizon/src/web/js/trove/image-lib.js#L516 and its use at https://github.com/brownplt/code.pyret.org/blob/horizon/src/web/js/trove/image-lib.js#L371, to deal with anti-aliasing. This is why `images-difference` renders...
This was a deliberate design choice (and one I think you'd suggested), to ensure that new files can't be saved as "Untitled" every darn time.
Are the `package-lock.json` changes necessary for this PR? If not, remove them... I'm not sure whether we want this change exactly this way, or not -- my initial aesthetic reaction...