code.pyret.org icon indicating copy to clipboard operation
code.pyret.org copied to clipboard

Published 20 hours ago • verified publisher icon brownplt

fix table borders in Firefox

Open thomascastleman opened this issue 4 years ago • 1 comments

For whatever reason tables have a rectangular border in Firefox.

with-border

I only noticed because I accidentally set the table border to be black for the default theme. This PR removes that border so that tables are consistent across browsers, but still allows themes to control the internal borders between table cells.

thomascastleman avatar Oct 01 '21 02:10 thomascastleman

Are the package-lock.json changes necessary for this PR? If not, remove them...

I'm not sure whether we want this change exactly this way, or not -- my initial aesthetic reaction was "hmm, I think I do want a border, but I want it to match the rounded corners of the table..." @jpolitz or others, thoughts?

blerner avatar Jan 17 '22 15:01 blerner

Closing this PR, since there's a cleaner (1-line!) CSS fix to make the borders hug the table more tightly. This will also give tight borders to rendered rows.

blerner avatar May 01 '24 16:05 blerner