blenk92

I tried this implementation (with valgrind) and I'm seeing this: ``` ==29674== Invalid read of size 8 ==29674== at 0x483F71C: memmove (vg_replace_strmem.c:1271) ==29674== by 0x10B92C: firehose_program_sparse (firehose.c:330) ==29674== by 0x10E5FF:...

> Hi Bjorn, > i have split all the patches. Also base source is there. Now it is much better. Also i have fixed mentioned above issue. > > Regards,...

> Hi, > are there any specific dependencies? Because i cannot build it. > ` make > > cc -O2 -Wall -g `xml2-config --cflags` -I libsparse/include -c -o firehose.o firehose.c...

> Now it works. I have tried to flash some images, but after first sparse image it exits. How is it verified? > [PROGRAM] flashed "abootbak" successfully > LOG: start...

> Sorry, but i could not share xml and images, because of "Company Policies" . > > Why you call firehose_program_sparse_callback at line 544, again? It brokes things on my...

> I will retry tomorrow. But what i understand when i read the libsparse code is that sparse_file_callback() process all the file at one pass with don't care chunks. Did...

> I mean that all "don't care chunk" are written during sparse_file_callback() and last call of firehose_program_sparse_callback() is not needed. Function that writes it is named callback_file_skip(). Also all data...

we have got this patch now in production for more than 6 months. Images have increased in size quite some and we haven't seen any issues (with quite some flashes...

@webdjoe Thanks for the quick reply. Added the check ;-)

@webdjoe anything else missing to get this merged?