Evain Arthur

Results 11 comments of Evain Arthur

Hello, can you post here the error logs?

Hello ! I'm new to the project and I would like to know if I can implement that as my first pr ? Thanks by advance !

Hello, is this issue still opened ? I would like to contribute to it

Hello ! Is this issue is relevant ? I would like to contribute to it

Hello, is it still relevant to implement this last feature ?

Hello ! Is this issue still relevant and can I be assigned to this if it is the case?

Hello @gorkem-bwl ! Thanks for the quick answer. I think I will start by changing all px sizes by equivalent rem size (using a converter), starting by this file :...

I have automated the task by using a python programm and using the conversion 1rem = 16px

Hello @ajhollid, thanks for the answer. I don't understand the issue : in the code you show, fonts are declared using rem, not px

In the file your talking about (https://github.com/bluewave-labs/Checkmate/blob/7df42357cdb3682150d6bcaad49eb5ac07d90374/src/Utils/Theme/constants.js#L1), it is written that every px should be replaced by rem ; that was the point of my pr (maybe the problem is...