Blake Johnson comments

Results 77 comments of


                                            Blake Johnson

Add BaseResult functionality to primitives module

@pedrorrivero with more thought, I think introducing an inconsistency with the rest of terra here would be not good. So, let's shelve my problem with the name `experiments` until we...

Add BaseResult functionality to primitives module

@ikkoham I am okay proceeding with this PR. I suggest that we revisit this question of the use of `experiments` in Qiskit holistically, because just changing it here would be...

OpenQASM3 paper refers to OpenQASM2 code while using indexed classical registers in conditional

Why is that not valid OpenQASM2? Seems more like an error in Qiskit's OpenQASM2 parser.

OpenQASM3 paper refers to OpenQASM2 code while using indexed classical registers in conditional

I see. Seems like the paper should reference 4 separate `creg`s to conform to OpenQASM2 syntax, then.

Openpulse reference implementation

Closes #296

RFC: `unitary` subroutines, as a gate-like subroutine acting on quantum registers and with more versatile control flow

I support the proposal.

What are the assumptions about stdgates.inc ?

In OpenQASM3 there is only one built-in gate at the language level: `U`. We have written `stdgates.inc` in the paper so that including that file will provide backward compatibility for...

Flesh out compile-time expressions and `const` types

@mbhealy volunteered to remove the `int`/`uint` change to the rotation operations.

In the event of a tie, the compiler should choose the defcal block that appeared last in the circuit, not the first

👍

Typing issues

Then how about an explicit array type? e.g. `array[bit[BITS], ARRAY_SIZE] a`