Blake Finney
Blake Finney
I've got a workaround for this now in my code but yeh like you say appears to be aggregation that won't check the rushing two points for players with no...
So deleting the JSON file won't give the correct plays? Assuming I would only be doing what you did which didn't get the change. Funnily enough, if it was an...
@ochawkeye Probably best to. In hindsight after running the update a few times I noticed it slowed significantly. Would update the gsis_id function to fetch both essentially and feed it...
Improving efficiency. Make sure nflgame Player object has the "esb_id" passed through
@ochawkeye @BurntSushi I've been trying to see when the gsis_id function (here: https://github.com/blakefinney/nflgame/blob/5af4de168872493fbd315d92c3adda0ff8e9ba45/nflgame/update_players.py#L116 ) is called. But I think it only gets called when a player isn't in nflgame yet...
@ochawkeye It's not the same issue (multiple commas in names) as I've already patched that myself. It's a different one I believe, the same one as in this issue: https://github.com/BurntSushi/nflgame/issues/202
How about this guys? Still works in a similar way to the original PR I submitted, but when reading a row for a rostered player it checks if it's on...
@ochawkeye I've actually been working on doing it slightly differently. One of the other features that I was curious about was player's injury status leading up to a game. I've...
Awesome! No rush @pocesar :)