Blake Embrey

Oh wait, it's in your screenshot, this seems like a regression in Express and not `path-to-regexp`. Trying to coerce this in `path-to-regexp` would have hidden this bug.

@wesleytodd Looks like it may be a regression in Express, I have a short call to jump to now but can investigate it afterward.

I wonder if this was a bug in the documentation instead of Express, I suspect it's never actually worked before since the path generated wouldn't have started with `/` (as...

@az-faro I think we understand that, but if you commented out `app.put(express.raw({ type: '*/*' }))` the application probably works, in which case I'd be inclined to say either the documentation...

@alewitt2 We agree, but your application will start doing something it didn't do before, which could break your application. For example, if you change `app.put` to `app.use` and it doesn't...

@bjohansebas Would it make more sense for this to be in the repo instead of globally? The contents of https://github.com/expressjs/.github/pull/5/files seem to imply that it's more website specific and doesn't...

It looks like I'm basically reverting https://github.com/pillarjs/finalhandler/commit/3fe2b5e4480b3eb67f6eef1da3797e2f8039d7e2 so I'll try and figure out why this was added to begin with. Edit: I can't find a good reason.

Haha 😅 OK @wesleytodd, take it or leave it is fine, also just as easy to bump to v2 of `encodeurl` instead. Feel free to close if you don't want...

Thanks @dougwilson for dealing with the reports all these years! It's definitely not fun, all good if you can't find it specifically.

I don't think there's any decision here, and it's your decision as the maintainer for the package. I don't mind either way, please close the PR if you prefer to...