Results 723 comments of Blake Embrey

@wesleytodd Why can't we can do a major version? You can just upgrade in express v5 or v6 when you're comfortable with it. A backward incompatible API change in this...

> My push for avoiding it is much more because of the complexity of maintaining multiple major lines over the next 2-3 years. This is not necessarily true. The maintenance...

> What do you think about my goal of landing this stuff in node core? I think it's a worthwhile goal, but at the same time my goal for a...

I'm confused by the two sentences: that goal is good, we don't know what the goal is. What working group am I meant to be asking to do work on...

I also feel like we're now drifting away from the original discussion, which is that we could do a major release to fix the current API but keep the functionality...

I'm going to close this as won't fix since we aren't doing a major release. However, this package is just a tiny wrapper and I already back ported and fixed...

@jonchurch That's my bad, I don't think I was clear, when I wrote: > I'd love to take a strong stance either way I meant I'd prefer no configuration. Revisiting...

This has been resolved with the 4.20.0 release.

@az-faro what are you using as input if it’s not a string, array, or regex? This library shouldn’t be trying to coerce non-strings since that will hide important bugs in...

So that's specific to `.use`, and isn't supported in regular methods. Did you test these ever worked? If they were passed to `path-to-regexp` and generated routes it was just the...