David Arnold
David Arnold
@NagariaHussain I originally wanted to submit this after https://github.com/frappe/frappe/pull/23931, but since that one is stuck a bit and the presence of this legacy code is a hindrance here and there,...
not intended to go stale
@ruthra-kumar yes, please, this is a crucial stepping stone for: - https://github.com/frappe/erpnext/pull/40845 (wip) - hence: https://github.com/frappe/payments/pull/53 (wip) - thus contributing my PayZen integration (undergoing 3rd iteration, atm) :smile: (I just...
@ruthra-kumar it is still green as a package, but you might want to review the *feature* of https://github.com/frappe/erpnext/pull/40424 first. That PR also boast of additional test coverage, establishing a new...
Lore ipsum ...
Closing this in order to focus on https://github.com/frappe/erpnext/pull/40845
@ruthra-kumar This is now fully tested and, imo,looks good.
@ruthra-kumar I managed to reorganize the commits so that it now implements something akin to TDD: each commit is atomically green on the provided tests (`bench run-tests --doctype "Payment Request"...
@ruthra-kumar Is there a way that we could advance on this, as well? After yesterday's test & typing sprint on `frappe/payments` (not pushed yet, some cleanup to do) I'm starting...