frappe
feat(payment): add more payment channels than just email and phone (think: chat)
Revival of partially reviewed and then stale-bot terminated: #37448 (see there for context)
no-docs
@ruthra-kumar I managed to reorganize the commits so that it now implements something akin to TDD: each commit is atomically green on the provided tests (bench run-tests --doctype "Payment Request" --test test_payment_channels). It should now be easier to review.
@ruthra-kumar Is there a way that we could advance on this, as well?
After yesterday's test & typing sprint on frappe/payments (not pushed yet, some cleanup to do) I'm starting to see a reasonable design emerging for a generic payment controller over in my branch and getting this PR here ready to be upstreamed (and to a lesser extend https://github.com/frappe/erpnext/pull/40842) would help raise my confidence and avoid forcing me to pause the sprint.
It would do so by helping to hedge my risks by branching too far, something that might eventually overstretch my resources and focus.
I'm more than happy to expeditiously put in any extra work necessary for this PR :handshake:
And thanks to you, specifically, for the great collab, so far! It has been a pleasure! It's a real privilege to have such expert pairs of eyes on my (user-programmer) code-output.
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
@ruthra-kumar @s-aga-r could someone please help out and engage with this PR?
Please help to get the complexity and diff of https://github.com/frappe/erpnext/pull/40845 down, by reviewing and merging this PR or alternatively https://github.com/frappe/erpnext/pull/40842 which includes this PR.
closing this in order to focus on https://github.com/frappe/erpnext/pull/40845