David Arnold

Results 1203 comments of David Arnold

> The important thing is this: to be able at any moment to sacrifice what we are for what we could become. - Charles Dubois --- Kindly help move this...

> Obstacles are those frightful things you see when you take your eyes off your goal. - Henry Ford --- Kindly help move this PR forward. Many thanks from Yours...

> Our distrust is very expensive. - Ralph Emerson --- Kindly help move this PR forward. Many thanks from Yours Sincerely!

> An invincible determination can accomplish almost anything and in this lies the great distinction between great men and little men. - Thomas Fuller --- Kindly help move this PR...

More exploration from my side: https://github.com/barredterra/erpnext/pull/1 (Edi Template & Edi Log, squashed your naming fix there, @barredterra )

> It is not obvious (and was not intended by me) that the CanonicalVersionUri now has to be used as the name of the code list (for the import to...

> [ ... ] we should at least offer the import from the list view (or from an unsaved form) instead of from the saved form view. It would be...

https://github.com/frappe/erpnext/pull/43425/commits/d540d03d8a5903764c311b8d19c3d7cb3188e6d9 ![image](https://github.com/user-attachments/assets/e6d5caca-de0b-4373-bbe5-ce5a76454bbd)

We may need to relax the unique condition on `code` for _Common Code_. This is a valid Code List: ```xml 1.50 ReteFuente Compras con tarjeta débito o crédito 1.50 ReteFuente...

Problem addressed, also in the importer: ![image](https://github.com/user-attachments/assets/fa931e15-b20a-4252-a34e-bd5de3712baf) ![image](https://github.com/user-attachments/assets/e3f5e4f3-ea7c-4e35-89df-4f7b9b1bd99c)