David Arnold

Results 1203 comments of David Arnold

> But rather than using an environment variable I would just use the user configuration. I guess this is not sth you want to change often. Absolutely! That makes total...

> Both installables and runnables block types provide a build action. However, both block types also provide further actions. This makes them less than ideal for some use cases, such...

I believe the predominant pattern for downstream extensions of upstream behaviour is to declare hooks. While I personally also prefer inheritance, in this case I agree that the overall frappe-style...

I'm on the road, so I'll be brief / sparse: In Frappe: - There's a function (forgot the name) to retrieve hooks, say `frappe.get_hooks` (?) - Revise how that method...

> In this case, so you think, the Bulk Transaction featurs/doctypes should be moving into Frappe instead of ERPNext. That's not necessary or implied. You can (should) leave the implementation...

@ruthra-kumar this seems a sufficiently small & useful change. The author already uses it downstream in localization, my motion would be to merge.

needs: https://github.com/frappe/erpnext/pull/43100

You probably should also change the column value on the doctype.

@kalungia Thanks, can you quickly verify if the patch now becomes a no-op or is redundant, and share the results? If it's redundant, please remove to not pretend otherwise through...

A little more configurability would be nice, indeed. In the following debug log, we'd want to clean those within a `.data` path according to `PRJ_DATA_HOME="${PRJ_ROOT}/.data"` or `PRJ_DATA_HOME="${XDG_DATA_HOME}/prj/${PRJ_ID}"` (https://github.com/numtide/prj-spec/blob/main/contrib/direnv). ``` DEBUG...