Ben Young (ERG)

Results 45 comments of Ben Young (ERG)

Thank you Sebastian, this query works just fine. I might add that having the bulk-replace tool automatically also replace flows in impact methods seems problematic. In many cases, wanting to...

FBAs and FBSs for these models have been added to sharepoint. This PR will remain in draft until the final csv files are published by EPA.

Review those exiobase sectors that don't match at all - those are likely to be in this "other" category

USED data was getting dropped because the sector mapped to USED from exiobase has no exports to the US (in exiobase). this is fixed with https://github.com/USEPA/USEEIO/commit/bf995e5887d0a9d425c783602cc29697c37f2d20

This also is slowing the [CI/CD test](https://github.com/USEPA/flowsa/blob/master/.github/workflows/python-app.yml) substantially

adjusted FBS method testing in https://github.com/USEPA/flowsa/commit/ea115eb5b422fafaf5cf107a02b99966ecb51432

@WesIngwersen I've updated the validation after fixing an error in the 2012 FBS, see here: https://github.com/USEPA/GHGbyindustrydocs/commit/3112d40647715f7ab9c4ba9901a8aa3d9c4bb0bd. We still have one minor issue in m2 for 2012-2016, where emissions from liming...

Yes there are a few lingering issues in a handful of tables that i'm working through. Feel free to document any more that you see here.

> I see that for 2016, that row is identified as being less than 0.05 MMT (specific value not given). Is that why it's excluded? If so, maybe there's a...

This is really something that needs to be implemented for each specific FBA. We have a few examples now where this is done: EIA MECS: https://github.com/USEPA/flowsa/blob/0d44ae9de372640d63926eb26208cbb31ec3665d/flowsa/data_source_scripts/EIA_MECS.py#L426-L432 Census SAS: https://github.com/USEPA/flowsa/blob/c18da34e36856ffb8aeebbbbc9ea07dee53e04fa/flowsa/data_source_scripts/Census_SAS.py#L66-L82 GHGI:...