Ben Konyi

Results 375 comments of Ben Konyi

There's currently no way to set breakpoints in macros as we're still finalizing implementation details for the feature and haven't started much serious investigation into what the macro development tooling...

@sigmundch sorry for the delay. We should move this over to the Flutter repo under the tool and explicitly dump stdout/stderr from the `dart compile js` invocation on failure if...

This was changed because google3 makes heavy use of symlinks and CLI artifacts were never guaranteed to be in the same directory as the CLI executable after the symlinks were...

@dcharkes, I'm unable to reproduce at HEAD: ```bash bkonyi@bkonyi-glinux:~/dart-sdk/sdk/third_party/pkg/native/pkgs/native_assets_cli/example/build/native_add_app$ echo $DART_RELEASE /usr/local/google/home/bkonyi/dart-sdk/sdk/out/ReleaseX64/dart-sdk/bin/dart bkonyi@bkonyi-glinux:~/dart-sdk/sdk/third_party/pkg/native/pkgs/native_assets_cli/example/build/native_add_app$ $DART_RELEASE --enable-experiment=native-assets build bin/native_add_app.dart Deleting output directory: /usr/local/google/home/bkonyi/dart-sdk/sdk/third_party/pkg/native/pkgs/native_assets_cli/example/build/native_add_app/bin/native_add_app/. Building native assets. Writing native_assets.yaml. Copying 1 build assets:...

I'm also unable to reproduce with `3.5.0-243.0.dev` downloaded from the [SDK archives page](https://dart.dev/get-dart/archive).

> > Does this SDK need to be downloaded for the issue to be reproduced? > > It's reliably reproducing on the GitHub CI downloading the SDK, see the links...

Hm, maybe we should be using [FileSystemEntity.typeSync](https://api.dart.dev/stable/3.4.4/dart-io/FileSystemEntity/typeSync.html) instead of `File.existsSync`, which appears like it might return `false` if we're checking the path to a `Link` object.

The fix for this CL should be cherry-picked into beta/stable when the window opens again.

> > I think we also need an API that a DTD client can call to `getRegisteredServices` or similar. > > Do we need this too? I think when a...

That makes sense. Allowing for services to provide capabilities SGTM.