Bart Koelman

Results 276 comments of Bart Koelman

> > Coding style is validated during PR build, where we inject an extra settings layer that promotes various suggestions to warning level. This ensures a high-quality codebase without interfering...

That sounds like a warning from `inspectcode`, not `cleanupcode`.

> Shouldn't `cleanupcode` take care of applying a fix? You could ask JetBrains for that, but I suspect the answer is "no". `cleanupcode` optimizes whitespace, line breaks, etc. It's unaware...

> In this example I didn't get any feedback from the IDE but the inspection failed with > > > Warning: test\OpenApiTests\Headers\HeaderTests.cs:59 LocalFunctionCanBeMadeStatic: Local function 'AssertEtag' can be made static...

~No, because they cause intermediate warnings while writing code.~ Actually, I don't understand your point. What do you mean exactly?

Thanks. I'm out for the rest of this week, will take a look when I get back. Please do add anything related to headers in this PR. Maurits probably missed...

> The argument name if_None_Match is not great Can we use https://github.com/RicoSuter/NSwag/issues/808 somehow? > It throws on 403 We have https://github.com/json-api-dotnet/JsonApiDotNetCore/blob/openapi/src/JsonApiDotNetCore.OpenApi.Client/ApiResponse.cs for that; probably needs to be adapted to handle...

> > Can we use [RicoSuter/NSwag#808](https://github.com/RicoSuter/NSwag/issues/808) somehow? > > Probably but I'm not sure we can use by just passing a command line option so maybe that will fall outside...

Also, NSwag doesn't always detect changes properly. For example, if project options have changed but the source swagger.json has not, it won't regenerate. Delete the `obj` directory in the client...

@verdie-g Looking at your last commit message, you may have faced the same mystery as I did this week. See #1463.