Bart Koelman

Results 276 comments of Bart Koelman

I'm very well aware of the performance implications when recreating `JsonSerializerOptions` each time. But how is that relevant here? As far as I know, NSwag uses Newtonsoft, which doesn't have...

@RicoSuter @ErikPilsits-RJW Please keep in mind that `HttpClient` and the serializer are the ultimate extensibility points to control anything from general-purpose code that doesn't rely on an OpenAPI-specific shape. Would...

For context, our [project](https://www.nuget.org/packages/JsonApiDotNetCore/) is the most popular .NET server implementation of the JSON:API protocol, for which [200+ libraries](https://jsonapi.org/implementations/) exist in various languages. Our project is used by thousands of...

@ErikPilsits-RJW Thanks for responding. I understand your intent to guide unfamiliar developers from falling into the trap of recreating unneeded instances. However, the way it was implemented in NSwag goes...

Thanks for the proposal. I'd prefer something simpler, how about this? ```c# [GeneratedCode("NSwag", "...")] public partial class ApiClient { private static readonly JsonSerializerOptions DefaultSerializerSettings = JsonSerializerOptions.Default; private HttpClient _httpClient; private...

Makes sense. My proposal is just one way of addressing this. Reducing that to maximize backward compatibility sounds like a good next step. To clarify, the _bare minimum_ we need...

Still no update? I'd be happy to submit a PR that's fully backwards compatible, as proposed by @TWhidden.

Created #4888, which is fully backwards compatible.

This is intentional. It's all explained at https://github.com/json-api-dotnet/JsonApiDotNetCore/blob/master/.github/CONTRIBUTING.md#pull-requests.