Benjamin Klebel-Knobloch

Results 17 comments of Benjamin Klebel-Knobloch

> Huh, I never understood our "adapter" as a (GoF) design pattern, but as encapsulating the hardware comm/protocol side of things (as opposed to the command set, which belongs to...

EDIT: @bilderbuchi was faster. my version of an answer: afaik Mixins can inherit anything and everything which can be inherited in python, and thus they can e.g. be derived from...

Well, yes, I do like it too, I just tend to sometimes disregard good practice and wildly add functionalities via Mixins because it's so convenient - this can be dangerous,...

Separately from listing these approaches in an agnostic way (I hope), in this naming, I prefer the Dynamic Adapter level Mixin. Changes to the codebase and the structure of the...

I have added another approach, according to the last two comments by @msmttchr. I have to admit, I am now not sure I understand what you prefer in total, and...

I just now found #102 which is all about documentation. I guess I will change this PR here to fully address @bilderbuchi's point about "common pattern: inheritance between instrument models",...

Currently only 2D input is supported (images, matrices, ...) as this was what I needed - an update to variable input dimensions (1d vectors, scalars, cubic matrices, ...) is under...

PR updated for functionality - now also non-2D arrays can be processed. the bug failing all checks was removed - should be fully functional now!

For anyone who wants to use this already, in /rl/callbacks.py, in the lines 191-193, the np.mean/min/max need to be exchanged (e.g. with 0) because numpy cannot calculate the mean of...

I found some problems with nonzero window lengths in memories, I will continue working on it