Bogumił Kamiński

fix induced_subgraph indexing with vector of Bools

4

Currently both `getindex` and `induced_subgraph` handle `AbstractVector{Bool}` argument in a way inconsistent with Julia Base rules.

Performance of diameter

8

I have a `gh` graph on 37700 vertices and 289003 edges. Calculation of its diameter like this: ``` maximum(maximum(gdistances(gh, i)) for i in vertices(gh)) ``` takes around 250 seconds (probably...

Consider moving PrettyTables.jl to JuliaData

6

Since PrettyTables.jl is for Tables.jl I would move it to JuliaData. In this way we will make sure it is more discoverable and potentially gets more support (which might be...

Re-export Names

2

I think it would be nice if we re-export `Names` from NamedArrays.jl. Is it OK with you?

Reexport Name from NamedArrays

2

I think we should reexport Name from NamedArrays in this package?

Creation of `missing` entry even if it is not present

1

I think in such cases `missing` should not appear as level in the output: Case 1: ``` julia> freqtable(categorical(["a", 'b'])) 3-element Named Array{Int64,1} Dim1 │ ────────┼── a │ 1 'b'...

bug in freqtable on Vector{Any}

9

The following code fails: ``` julia> freqtable(Any[1,3]) ERROR: BoundsError: attempt to access 2-element Array{Int64,1} at index [3] ```

This is a TODO issue following discussion in #20 about using `SubArray` in `_freqtable` implementation. I plan to go back to a PR related to this when I am clear...

Cases in with convert has dispatch ambiguity

3

We have the following behaviors: ``` julia> convert(Union{}, 1) ERROR: MethodError: convert(::Type{Union{}}, ::Int64) is ambiguous. Candidates: julia> convert(Missing, 1) # the same - falls back to the previous one internally...

Fix error messages for ranges with missing

2

@nalimilan - this is a common error. First a case when I think error message is OK (or at least acceptable): ``` julia> missing:1:missing ERROR: TypeError: non-boolean (Missing) used in...