Björn Svensson
Björn Svensson
CI fails due to the required files are not existing yet, i.e: tls-certs/ca.crt tls-certs/ca.key tls-certs/redis.crt tls-certs/redis.key
This issue could most probably be solved by #119
#1012 didn't change how the pubsub handling was done from start for RESP2, but it made sure unsubscribe in RESP3 works the same (no longer calling the registered push-callback). It's...
> As I understand, there is no difference between the `MESSAGE`s sent to subscribers from `PUBLISH` or `SPUBLISH` commands. Ah, you are right! That's an interesting twist..
There are ongoing discussions regarding this problem in https://github.com/redis/redis/issues/10748
The parse double and parse bool testcases are now already covered via https://github.com/redis/hiredis/commit/d6a0b192b414dc261589d4c2d16577c2192b39c0. The other testcases would increase coverage.
> Any idea what could cause it to skip the tests? You might already have found the reason, but the command `DEBUG SLEEP` which is needed by these testcases was...
This issue seems to describe what is fixed on master by #1036.
As a note: all parts except enabling warning as errors and sds.h pragmas was delivered via https://github.com/redis/hiredis/pull/851
This looks like the same issue as in KjellKod/g3log/issues/282. hiredis have a disabling of `__attribute__(x)` in [sds.h](https://github.com/redis/hiredis/blob/master/sds.h#L38) for MS C/C++ compilers, which seems needed by ``.