bjornpiltz

Results 6 comments of bjornpiltz

I ran in to this and the problem seems to be the stray `/EHsc` passed to nvcc (the unquoted one). If I remove it, I can get a single nvcc...

@dennis2society I fixed the 4996 warnings by defining CREATE_QGLVIEWER_DLL, which was missing. see 20f8aa5a1d9e6ab5f1554b290c27ebe1d858347d. As of now, building libQLViewer as a DLL is hard coded in the cmake system. It's...

I think I'd prefer not to add #76 to keep this PR minimal. Anyway, I think a cleaner implementation would be: ```cmake if(QGLVIEWER_BUILD_EXAMPLES) add_subdirectory(examples) # details in examples/CMakeLists.txt endif() ```...

@dennis2society, I'm hesitant to do so since I don't understand the changes made in ["Minor tweaks in cmake configuration"](https://github.com/GillesDebunne/libQGLViewer/commit/3050415b2b81c164b21be470de19eac7331a75b8) I don't know why the minimum CMake version was raised as...

Does https://github.com/GillesDebunne/libQGLViewer/pull/71 this fix the problem?

Great! #71 has been superseded by #80, which also adds a MSVC2019 build job to the CI.